chore: make groups lower case for caseless email comparison#132
Merged
Conversation
davidnuescheler
marked this pull request as draft
April 17, 2025 21:17
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 39 39
Lines 2163 2163
=======================================
Hits 1641 1641
Misses 522 522 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auniverseaway
approved these changes
Aug 18, 2025
Member
|
This only affects the ACL trace and doesn't solve the overarching problem we have with case sensitivity, but should be mergeable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it would be great to lower case emails, to get to a case less comparison.
i think that IMS always returns them lower case, but i am not sure if this would break something relative to the IMS orgs which seem to be uppercase
adobe/da-live#421